Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31783: Fixed RichTextEmbedAllowedContentTypes subscriber implementation #1539

Merged
merged 1 commit into from
Sep 25, 2020
Merged

EZP-31783: Fixed RichTextEmbedAllowedContentTypes subscriber implementation #1539

merged 1 commit into from
Sep 25, 2020

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Sep 24, 2020 •
edited
Loading

Question Answer
Tickets https://jira.ez.no/browse/EZP-31783
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Follow up for #1441. Fixed few issues in previous implementation:

Additionally provided basic unit tests for \EzSystems\EzPlatformAdminUi\UniversalDiscovery\Event\Subscriber\RichTextEmbedAllowedContentTypes

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@adamwojs adamwojs self-assigned this Sep 24, 2020
@adamwojs adamwojs added the Bug label Sep 24, 2020
tomaszszopinski
tomaszszopinski approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform-ee 2.5 with diff.

@adamwojs adamwojs merged commit 551e7c2 into 1.5 Sep 25, 2020
@adamwojs adamwojs deleted the ezp_31783_follow_up branch September 25, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@ViniTou ViniTou ViniTou approved these changes

@alongosz alongosz Awaiting requested review from alongosz

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

Assignees

@adamwojs adamwojs

Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamwojs @ViniTou @tomaszszopinski