Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-426: Created additional UDW config for adding Location to Content #1772

Merged
merged 3 commits into from
Jun 16, 2021
Merged

IBX-426: Created additional UDW config for adding Location to Content #1772

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cde01a
IBX-426: Created additional UDW config for adding Location to Content
barw4 Jun 1, 2021
9ed3ccc
IBX-426: CS
barw4 Jun 2, 2021
bb63cc3
IBX-426: Applied review remark
barw4 Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/bundle/Resources/config/universal_discovery_widget.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,5 @@ system:
multiple_user_group:
multiple: true
allowed_content_types: ['user_group']
add_location:
multiple: false
2 changes: 1 addition & 1 deletion src/bundle/Resources/views/themes/admin/content/tab/locations/tab.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@

{% macro table_header_tools(form_add, form_remove, can_add) %}
<button
data-udw-config="{{ ez_udw_config('single', {}) }}"
data-udw-config="{{ ez_udw_config('add_location', {}) }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this one. @Nattfarinn correct me if I'm wrong but changing config name here is a BC break in case someone already used custom configuration for single.

Copy link
Contributor

@Nattfarinn Nattfarinn Jun 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a tiny risk of bahavioral BC here, but I wouldn't bother much with it. I don't think anyone ever would change our generic single configuration to be anything else but multiple: false (and even if he did we don't change configuration itself [big BC], but configuration key used just for this use-case).

class="btn btn-icon btn--udw-add"
title="{{ 'tab.locations.action.add'|trans|desc('Add Location') }}"
{{ not can_add ? 'disabled' }}>
Expand Down
34 changes: 34 additions & 0 deletions src/lib/UniversalDiscovery/Event/Subscriber/AddLocation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<?php

/**
* @copyright Copyright (C) eZ Systems AS. All rights reserved.
* @license For full copyright and license information view LICENSE file distributed with this source code.
*/
declare(strict_types=1);

namespace EzSystems\EzPlatformAdminUi\UniversalDiscovery\Event\Subscriber;

use EzSystems\EzPlatformAdminUi\UniversalDiscovery\Event\ConfigResolveEvent;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;

class AddLocation implements EventSubscriberInterface
barw4 marked this conversation as resolved.
Show resolved Hide resolved
{
public static function getSubscribedEvents(): array
{
return [
ConfigResolveEvent::NAME => ['onUdwConfigResolve', -10],
];
}

public function onUdwConfigResolve(ConfigResolveEvent $event): void
{
if ($event->getConfigName() !== 'add_location') {
return;
}

$config = $event->getConfig();
$config['allowed_content_types'] = null;

$event->setConfig($config);
}
}