Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-902: Fixed field groups in content on the fly edit #1886

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

damianz5
Copy link
Contributor

@damianz5 damianz5 commented Sep 3, 2021

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-902
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Fixed field groups in content on the fly edit

requires: ezsystems/ezplatform-content-forms#46

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@damianz5 damianz5 force-pushed the IBX-902-cotf-field-tabs branch 2 times, most recently from 0331436 to 26c37e2 Compare September 3, 2021 21:45
@damianz5 damianz5 force-pushed the IBX-902-cotf-field-tabs branch from 26c37e2 to 0cde52d Compare September 6, 2021 09:25
@damianz5 damianz5 changed the title IBX-902: When creating content on the fly doesn't have categories tabs IBX-902: Fixed field groups in content on the fly edit Sep 6, 2021
@damianz5 damianz5 marked this pull request as ready for review September 6, 2021 09:29
@@ -354,6 +363,9 @@ private function buildEditView(
'language' => $language,
'content_type' => $contentType,
'form' => $form->createView(),
'grouped_fields' => $this->groupedContentFormFieldsProvider->getGroupedFields(
$form->get('fieldsData')->all()
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only note is here, that field grouping should be done in the form type itself, during buildView method.

@damianz5 damianz5 requested a review from a team September 7, 2021 07:46
@ciastektk ciastektk requested a review from a team September 7, 2021 07:58
@mikadamczyk mikadamczyk requested a review from a team September 7, 2021 08:05
@GrabowskiM GrabowskiM force-pushed the 2.3 branch 2 times, most recently from 12df4e9 to e436c4d Compare September 7, 2021 13:26
@tomaszszopinski
Copy link
Contributor

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on Ibexa DXP 3.3.x-dev with diff.

@Nattfarinn Nattfarinn merged commit 0aa7fb6 into 2.3 Sep 13, 2021
@Nattfarinn Nattfarinn deleted the IBX-902-cotf-field-tabs branch September 13, 2021 06:52
@Nattfarinn
Copy link
Contributor

@damianz5 Please merge up to master and do fast-forward merge to ibexa org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

8 participants