-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-902: Fixed field groups in content on the fly edit #1886
Conversation
0331436
to
26c37e2
Compare
26c37e2
to
0cde52d
Compare
@@ -354,6 +363,9 @@ private function buildEditView( | |||
'language' => $language, | |||
'content_type' => $contentType, | |||
'form' => $form->createView(), | |||
'grouped_fields' => $this->groupedContentFormFieldsProvider->getGroupedFields( | |||
$form->get('fieldsData')->all() | |||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only note is here, that field grouping should be done in the form type itself, during buildView
method.
12df4e9
to
e436c4d
Compare
Successful Travis build: https://app.travis-ci.com/github/ezsystems/ezplatform-admin-ui/jobs/536619485 |
5d12654
to
0cde52d
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on Ibexa DXP 3.3.x-dev with diff.
@damianz5 Please merge up to |
Fixed field groups in content on the fly edit
requires: ezsystems/ezplatform-content-forms#46
Checklist:
$ composer fix-cs
)