Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZEE-3213: Added verification if the user has section/view permission #2016

Merged
merged 3 commits into from
Nov 29, 2021
Merged

EZEE-3213: Added verification if the user has section/view permission #2016

merged 3 commits into from
Nov 29, 2021

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
Tickets EZEE-3213
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Verification of permission according to other forms in our platform

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mateuszdebinski mateuszdebinski requested a review from a team November 25, 2021 19:40
@mateuszdebinski mateuszdebinski self-assigned this Nov 25, 2021
webhdx
webhdx suggested changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@webhdx webhdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a reliable way to check permissions. Simply use PermissionResolver and inject additional variable to the Twig template.

@mateuszdebinski mateuszdebinski requested review from webhdx and a team November 26, 2021 08:40
webhdx
webhdx suggested changes Nov 26, 2021
View reviewed changes
src/bundle/Controller/TrashController.php Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

kacper-wieczorek-ibexa
kacper-wieczorek-ibexa approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA - approved. Tested on 3.3.12 experience, commerce.
It is possible to open trash as editor.

@mikadamczyk mikadamczyk merged commit 88b20fe into 2.3 Nov 29, 2021
@mikadamczyk mikadamczyk deleted the EZEE-3213_permission_section_in_trash branch November 29, 2021 10:53
@lserwatka
Copy link
Member

@mateuszdebinski you must merge it to ibexa/admin-ui:main

@mateuszdebinski mateuszdebinski mentioned this pull request Dec 2, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa kacper-wieczorek-ibexa approved these changes

@konradoboza konradoboza konradoboza approved these changes

@dew326 dew326 dew326 approved these changes

@webhdx webhdx webhdx approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

Assignees

@mateuszdebinski mateuszdebinski

Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mateuszdebinski @lserwatka @mikadamczyk @webhdx @dew326 @konradoboza @kacper-wieczorek-ibexa