Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-1648: Added redirect when the trash form has any error #2074

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-1648
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@micszo
Copy link
Member

micszo commented Oct 28, 2022

@mateuszdebinski does the second commit intentionally contain a different JIRA id?

@mateuszdebinski mateuszdebinski force-pushed the IBX-1648_back_to_the_image_when_an_error_occurs_during_the_remove branch from e532d57 to 45ce094 Compare October 28, 2022 07:38
@mateuszdebinski
Copy link
Contributor Author

@mateuszdebinski does the second commit intentionally contain a different JIRA id?

Thanks, corrected, it's wasn't intentional

@mikadamczyk mikadamczyk requested a review from a team November 29, 2022 11:55
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ViniTou ViniTou requested a review from a team November 30, 2022 07:47
@konradoboza konradoboza requested a review from a team November 30, 2022 07:48
@bogusez bogusez self-assigned this Dec 1, 2022
@mikadamczyk mikadamczyk merged commit e4f16e7 into 2.3 Dec 1, 2022
@mikadamczyk mikadamczyk deleted the IBX-1648_back_to_the_image_when_an_error_occurs_during_the_remove branch December 1, 2022 11:50
ViniTou pushed a commit that referenced this pull request May 12, 2023
* IBX-1648: Added redirect when the trash form has any error (#2074)

* IBX-1648: Added redirect when the trash form has any error

* IBX-1648: Corrected CS

* Added condition to check if a location is not null

* Corrected CS

Co-authored-by: Mateusz Dębiński <mateusz.debinski@ibexa.co>

* IBX-4130: Optimized subitems fetching in UDW (#2080)

* IBX-4130: Optimized subitems fetching in UDW

* IBX-4130: CS

* IBX-4130: Hardcoded '0' as `childCount`

Co-authored-by: Mateusz Dębiński <58430570+mateuszdebinski@users.noreply.github.com>
Co-authored-by: Mateusz Dębiński <mateusz.debinski@ibexa.co>
Co-authored-by: Bartek Wajda <bartlomiej.wajda@ibexa.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants