-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-1648: Added redirect when the trash form has any error #2074
Merged
mikadamczyk
merged 4 commits into
2.3
from
IBX-1648_back_to_the_image_when_an_error_occurs_during_the_remove
Dec 1, 2022
Merged
IBX-1648: Added redirect when the trash form has any error #2074
mikadamczyk
merged 4 commits into
2.3
from
IBX-1648_back_to_the_image_when_an_error_occurs_during_the_remove
Dec 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mateuszdebinski does the second commit intentionally contain a different JIRA id? |
mateuszdebinski
force-pushed
the
IBX-1648_back_to_the_image_when_an_error_occurs_during_the_remove
branch
from
October 28, 2022 07:38
e532d57
to
45ce094
Compare
Thanks, corrected, it's wasn't intentional |
mikadamczyk
approved these changes
Nov 29, 2022
ViniTou
reviewed
Nov 29, 2022
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
ViniTou
approved these changes
Nov 30, 2022
konradoboza
approved these changes
Nov 30, 2022
bogusez
approved these changes
Dec 1, 2022
mikadamczyk
deleted the
IBX-1648_back_to_the_image_when_an_error_occurs_during_the_remove
branch
December 1, 2022 11:50
ViniTou
pushed a commit
that referenced
this pull request
May 12, 2023
* IBX-1648: Added redirect when the trash form has any error (#2074) * IBX-1648: Added redirect when the trash form has any error * IBX-1648: Corrected CS * Added condition to check if a location is not null * Corrected CS Co-authored-by: Mateusz Dębiński <mateusz.debinski@ibexa.co> * IBX-4130: Optimized subitems fetching in UDW (#2080) * IBX-4130: Optimized subitems fetching in UDW * IBX-4130: CS * IBX-4130: Hardcoded '0' as `childCount` Co-authored-by: Mateusz Dębiński <58430570+mateuszdebinski@users.noreply.github.com> Co-authored-by: Mateusz Dębiński <mateusz.debinski@ibexa.co> Co-authored-by: Bartek Wajda <bartlomiej.wajda@ibexa.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs
)