Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4125: Optimized Dashboard tabs #2075

Merged
merged 7 commits into from
Dec 1, 2022
Merged

IBX-4125: Optimized Dashboard tabs #2075

merged 7 commits into from
Dec 1, 2022

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Nov 2, 2022 •
edited
Loading

Question Answer
Tickets IBX-4125
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Dashboard-related queries were forced to utilize the LocationQuery instead of the Content/Query which is costly. Old QueryTypes were left intact to keep the BC policy.

Related ezplatform-workflow PR: https://github.com/ezsystems/ezplatform-workflow/pull/256

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 self-assigned this Nov 2, 2022
@barw4 barw4 requested a review from a team November 3, 2022 12:14
@barw4 barw4 requested review from webhdx and a team November 17, 2022 10:05
@barw4 barw4 requested a review from webhdx November 17, 2022 10:47
@barw4 barw4 requested a review from a team November 17, 2022 11:20
@konradoboza konradoboza requested a review from a team November 21, 2022 11:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tomaszszopinski
tomaszszopinski approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 3.3 commerce.

@webhdx webhdx merged commit 94b3384 into 2.3 Dec 1, 2022
@webhdx webhdx deleted the ibx-4125-optimize-dashboard branch December 1, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@konradoboza konradoboza konradoboza approved these changes

@webhdx webhdx webhdx approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@barw4 barw4

Labels
Improvement QA approved Ready for MERGE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@barw4 @webhdx @konradoboza @tomaszszopinski @mikadamczyk @Nattfarinn