Allowed usage with newer version of PHP-CS-Fixer #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Steveb-p
force-pushed
the
allow-php-cs-fixer-3.0
branch
from
602db1b to
535b53a
Compare
adamwojs
reviewed
Aug 31, 2021
adamwojs
approved these changes
Aug 31, 2021
@adamwojs added readme changes. See if they're to your liking. |
alongosz
requested changes
Aug 31, 2021
There was a problem hiding this comment.
To prevent issues with current packages that rely on 1.0 of this package, and can potentially have invalid code style check declarations (some deprecations are tied directly to php-cs-fixer call) I'd suggest making this a 2.0 release.
You need to change branch alias in composer.json then
|
Kudos, SonarCloud Quality Gate passed!
|
alongosz
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows installation with
3.0ofphp-cs-fixer.Since we've removed the deprecations, we're more than ready to mark this package as compatible with 3.0.
To prevent issues with current packages that rely on
1.0of this package, and can potentially have invalid code style check declarations (some deprecations are tied directly to php-cs-fixer call) I'd suggest making this a 2.0 release.Checklist:
@ibexa/engineering).