Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new configuration to enforce empty line between class properties #17

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Added new configuration to enforce empty line between class properties #17

merged 1 commit into from
Aug 27, 2021

Conversation

mikadamczyk
Copy link
Contributor

Question Answer
JIRA issue N/A
Type improvement
Target package version master
BC breaks no
Doc needed no

This PR adds a new configuration value to enforce empty line between class properties

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly.
  • Asked for a review (ping @ibexa/engineering).

@mikadamczyk mikadamczyk requested review from adamwojs, Steveb-p and a team August 23, 2021 06:39
@mikadamczyk mikadamczyk self-assigned this Aug 23, 2021
@mikadamczyk mikadamczyk force-pushed the empty_line_between_class_properties branch from a4fbab4 to da77bc7 Compare August 23, 2021 06:55
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Steveb-p Steveb-p mentioned this pull request Aug 23, 2021
Merged
6 tasks
@Steveb-p Steveb-p merged commit 142c0a8 into master Aug 27, 2021
@Steveb-p Steveb-p deleted the empty_line_between_class_properties branch August 27, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz Awaiting requested review from alongosz

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@mikadamczyk mikadamczyk

Labels
Improvement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikadamczyk @adamwojs @Steveb-p @ViniTou