This repository has been archived by the owner on May 27, 2020. It is now read-only.
EZP-30898: Changed Demo Installer parent in Symfony DIC #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
19 tasks
damianz5
approved these changes
Aug 29, 2019
alongosz
force-pushed
the
ezp-30898-change-installer-parent
branch
from
d825274 to
7fcbcde
Compare
micszo
approved these changes
Sep 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.0This PR sets Kernel (PlatformInstaller Bundle)
CoreInstallerasparentin Dependency Injection Container configuration to align both with the actual class implementation and the changes introduced via ezsystems/ezpublish-kernel#2751.It wasn't considered as a bug, because
CoreInstallerwas not explicitly defined in the Container in v2.5+, due to optional dependency on Doctrine Schema Bundle and resulting from that BC promise.