IBX-1431: Dropped support for PHPStorm configuration in favor of Ibex…

…a DXP Plugin (#40)
ezsystems · Jan 21, 2022 · 6e10a5c · 6e10a5c
1 parent 10c3f47
commit 6e10a5c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 64 deletions.
diff --git a/bundle/DependencyInjection/Compiler/PHPStormPass.php b/bundle/DependencyInjection/Compiler/PHPStormPass.php
diff --git a/bundle/DependencyInjection/Configuration.php b/bundle/DependencyInjection/Configuration.php
@@ -45,8 +45,12 @@ public function getConfigTreeBuilder()
                 ->end()
                 ->arrayNode('phpstorm')
                     ->addDefaultsIfNotSet()
+                    ->setDeprecated('The "%node%" option is deprecated since Ibexa DXP v3.3.14 and will be removed in 4.0. Use PhpStorm plugin instead: https://doc.ibexa.co/en/latest/community_resources/phpstorm_plugin/')
                     ->children()
-                        ->booleanNode('enabled')->defaultValue('%kernel.debug%')->info('Activates PHPStorm support')->end()
+                        ->booleanNode('enabled')
+                            ->defaultValue(false)
+                            ->info('Activates PHPStorm support')
+                        ->end()
                         ->scalarNode('twig_config_path')
                             ->info('Path where to store PHPStorm configuration file for additional Twig namespaces (ide-twig.json).')
                             ->defaultValue('%kernel.project_dir%')

diff --git a/bundle/EzPlatformDesignEngineBundle.php b/bundle/EzPlatformDesignEngineBundle.php
@@ -8,7 +8,6 @@
 
 use EzSystems\EzPlatformDesignEngineBundle\DependencyInjection\Compiler\AssetPathResolutionPass;
 use EzSystems\EzPlatformDesignEngineBundle\DependencyInjection\Compiler\AssetThemePass;
-use EzSystems\EzPlatformDesignEngineBundle\DependencyInjection\Compiler\PHPStormPass;
 use EzSystems\EzPlatformDesignEngineBundle\DependencyInjection\Compiler\TwigThemePass;
 use EzSystems\EzPlatformDesignEngineBundle\DependencyInjection\DesignConfigParser;
 use EzSystems\EzPlatformDesignEngineBundle\DependencyInjection\EzPlatformDesignEngineExtension;
@@ -30,7 +29,6 @@ public function build(ContainerBuilder $container)
         $container->addCompilerPass(new TwigThemePass());
         $container->addCompilerPass(new AssetThemePass(), PassConfig::TYPE_OPTIMIZE);
         $container->addCompilerPass(new AssetPathResolutionPass(), PassConfig::TYPE_OPTIMIZE);
-        $container->addCompilerPass(new PHPStormPass(), PassConfig::TYPE_OPTIMIZE);
     }
 
     public function getContainerExtension()