-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZEE-3003: Increased ezpage_attributes.value size limit #74
Conversation
@ezsystems/documentation-team please note this PR is dedicated for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I'd rather go for MEDIUMTEXT.
For two reasons:
- Columns of such width will cause the customer's database to fill up space extremely quickly in case of an error.
- Texts of that size will not fit into PHP's memory anyway in most cases - and even when they do, they will starve the server out of resources.
4GB is better choice here because we have to choose between 16MB and 4GB. 16MB is still a lot but I can image someone trying to write base64 encoded files or very large JSONs in it which could easily exceed 17MB and still be well below PHP capacity. Of course this is an example of very bad architecture but sadly this kind of stuff happens on integrators' side and then it gets reported as a bug in our software. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on 2.5 and 3.2, on both PostgreSQL and MySQL using a clean installation and upgrading an existing one (on MySQL).
I was able to enter large fragments of text (https://pastebin.com/WEa8FWAr) into the Code block and the upgrade procedure did not brek the existing block attribute entries.
QA Approved.
Thank you @mnocon ! Merging |
Could you merge it up? |
Description
This PR fixes issue where big Landing Page cannot be saved because size limit on
ezpage_attribues.value
column is exceeded. It usually happens on long Code Block or more advanced Schedule Block configurations.The solution to that issue is changing column type to
LONGTEXT
which maxes out at 4GB.MEDIUMTEXT
(16MB) could be a good choice but you never know what's going on in client databases... Postgres is not affected becauseTEXT
type has no size limit there.Upgrade guide
That change requires altering column configuration on current installations:
MySQL/MariaDB
Postgres
No changes needed.