Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZEE-2907: Removed dependency to flex-workflow #114

Merged
merged 1 commit into from
Dec 6, 2019
Merged

EZEE-2907: Removed dependency to flex-workflow #114

merged 1 commit into from
Dec 6, 2019

Conversation

pawbuj
Copy link
Contributor

@pawbuj pawbuj commented Oct 21, 2019 •
edited
Loading

@pawbuj pawbuj self-assigned this Oct 21, 2019
@Nattfarinn Nattfarinn mentioned this pull request Oct 30, 2019
Merged
@mnocon
Copy link
Member

mnocon commented Nov 5, 2019

Removing flex-workflow can result in incorrect notification info displayed.
Zrzut ekranu 2019-11-5 o 15 16 57

Steps:

  1. Login as admin
  2. Start creating a new Content Item: Folder
  3. Fill the required fields
  4. Send it to review using Flex Workflow (to Administrator user)
  5. Remove flex-workflow (applying changes from this PR)
  6. Login as admin again

Result:

  1. There is one unread notification, but the notification list is empty.

This can occur for all people migrating from 2.5 (current flex-workflow users) to 3.0, do we plan to provide any migration script that will all the flex-wf mark the notifications as read?

@Nattfarinn Nattfarinn merged commit a7983ff into master Dec 6, 2019
@Nattfarinn Nattfarinn deleted the EZEE_2907 branch December 6, 2019 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@adamwojs adamwojs adamwojs approved these changes

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@pawbuj pawbuj

Labels
Improvement Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pawbuj @mnocon @adamwojs @mikadamczyk @Nattfarinn