Fix EZP-30957: avoid exceptions on content types not in the generated schema #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunogier
force-pushed
the
ezp30957-ungenerated_types
branch
from
4ccbec9 to
4b759e1
Compare
bdunogier
force-pushed
the
ezp30957-ungenerated_types
branch
from
4b759e1 to
f077a1e
Compare
2 tasks
|
@bdunogier this PR no longer fixes the issue (it worked correctly before the name change), could it be because |
Yes, probably. I'll fix it right away. |
… schema After a content type has been added, but before the schema has been generated, trying to list a location's sub-items that contain one of those items will error out. The typeResolver of the DomainContent interface will return for items of those types a name that doesn't exist in the schema. To work around that, content items of types that don't exist in the schema are mapped to an "anonymous" type, "UntypedContent".
bdunogier
force-pushed
the
ezp30957-ungenerated_types
branch
from
f077a1e to
7db96bb
Compare
|
It should be fixed now @mnocon. |
mnocon
approved these changes
Sep 23, 2019
|
@bdunogier could you merge it up? |
|
Merged to master in 46a4032 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a content type has been added, but before the schema has been generated, trying to list
a location's sub-items that contain one of those items will error out. The typeResolver of the
DomainContent interface will return for items of those types a name that doesn't exist in the schema.
To work around that, content items of types that don't exist in the schema are mapped to an "anonymous" type, "UntypedContent". It has the properties shared by all content items (
_url,_name,thumbetc, but not the fields.TODO
Consider renaming the type.(done, toAnonymousContentUntypedContent)?