Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30934: Removed usage of deprecated getCurrentUser method #101

Merged
merged 1 commit into from
Sep 24, 2019
Merged

EZP-30934: Removed usage of deprecated getCurrentUser method #101

merged 1 commit into from
Sep 24, 2019

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Sep 10, 2019 •
edited
Loading

Question Answer
JIRA issue EZP-30934
Type Improvement
Target version master
BC breaks yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests + specs and passing ($ composer test)
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

alongosz
alongosz approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH too many out of scope changes :)

@ViniTou
Copy link
Contributor Author

ViniTou commented Sep 10, 2019

@alongosz
Everything was marked as warning in my phpstorm cuz of short array syntax and I just couldnt look at it ;)

@alongosz
Copy link
Member

@alongosz
Everything was marked as warning in my phpstorm cuz of short array syntax and I just couldnt look at it ;)

I usually create a separate PR :P

@lserwatka lserwatka merged commit aee9259 into master Sep 24, 2019
@lserwatka lserwatka deleted the ezp-30928-as_a_developer_i_want_deprecated_methods_and_parameters_to_be_dropped branch September 24, 2019 11:07
@michalmilc90 michalmilc90 mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnocon mnocon mnocon approved these changes

@alongosz alongosz alongosz approved these changes

@pawbuj pawbuj pawbuj approved these changes

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@webhdx webhdx Awaiting requested review from webhdx

Assignees
No one assigned
Labels
Improvement QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ViniTou @alongosz @pawbuj @mnocon @lserwatka