EZP-30562: Make it possible to ignore tags over configurable max length #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
force-pushed
the
EZP-30562_cut_tags_option
branch
from
09feab2 to
399f369
Compare
kmadejski
reviewed
Feb 7, 2020
kmadejski
reviewed
Feb 7, 2020
andrerom
force-pushed
the
EZP-30562_cut_tags_option
branch
from
399f369 to
7708fd5
Compare
mateuszbieniek
requested changes
Feb 10, 2020
mateuszbieniek
approved these changes
Feb 10, 2020
andrerom
force-pushed
the
EZP-30562_cut_tags_option
branch
from
86dc065 to
b3a5d17
Compare
ViniTou
approved these changes
Feb 11, 2020
kmadejski
approved these changes
Feb 13, 2020
micszo
approved these changes
Feb 14, 2020
There was a problem hiding this comment.
Retested successfully on eZ Platform EE 2.5 with changes as in ezsystems/ezplatform#499 and with diff from this PR.
Tested on Apache + FPM with and without Varnish.
Thanks to @kmadejski for the idea how to reproduce!
andrerom
added a commit
that referenced
this pull request
Feb 17, 2020
|
Merged in c94402b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.0Even if 1.0 shortens tags, it still is possible to reach the limit. On Apache (4k) and Fastly (16k) this is supposedly not configurable, so this makes it possible to cut the header, and apply a lower TTL to compensate for the risk of stale cache.
Closes #104, which proposed this for 0.9. Feature fits better with 1.0 where tags are shortened, and which is new feature release.
TODO:
$ composer test)$ composer fix-cs).