-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-28034: Refactored to use EzPlatformRestBundle #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
4 tasks
ViniTou
force-pushed
the
EZP-28032-rest-common
branch
from
May 20, 2019 13:25
dfd1e46
to
f67087c
Compare
ViniTou
force-pushed
the
EZP-28032-rest-common
branch
3 times, most recently
from
May 21, 2019 14:19
ad8d656
to
28ec32e
Compare
Same story as in ezsystems/ezplatform-admin-ui#989. |
alongosz
changed the title
EZP-28034: Create ezsystems/ezplatform-rest-common package
EZP-28034: Refactored to depend on EzPlatformRestBundle
May 22, 2019
alongosz
requested changes
May 22, 2019
ViniTou
force-pushed
the
EZP-28032-rest-common
branch
2 times, most recently
from
May 22, 2019 14:09
2446cb5
to
71a39c0
Compare
mnocon
reviewed
May 23, 2019
alongosz
reviewed
May 23, 2019
alongosz
requested changes
May 23, 2019
ViniTou
force-pushed
the
EZP-28032-rest-common
branch
from
May 23, 2019 11:37
71a39c0
to
b97ca9c
Compare
alongosz
approved these changes
May 23, 2019
mnocon
approved these changes
May 24, 2019
alongosz
changed the title
EZP-28034: Refactored to depend on EzPlatformRestBundle
EZP-28034: Refactored to use EzPlatformRestBundle
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desc
Extract RestBundle and Common namespace to new package.
ezsystems/ezpublish-kernel#2630
https://github.com/ezsystems/ezplatform-rest
BC
as of
ezpublish-kernel 8.0
, support for php5.6 and 7.0 must be dropped. As it seems there is no way to includeezplatform-rest
basing onezpublish-kernel
version. So this would have to be version1.0
.