Addressed issues from code review

ezsystems · Apr 2, 2020 · 3b2c1f7 · 3b2c1f7
1 parent a55831b
commit 3b2c1f7
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 8 deletions.
diff --git a/eZ/Bundle/EzPublishCoreBundle/EventListener/CacheViewResponseListener.php b/eZ/Bundle/EzPublishCoreBundle/EventListener/CacheViewResponseListener.php
@@ -51,7 +51,7 @@ public function configureCache(ResponseEvent $event)
 
         $isTtlCacheEnabled = $this->configResolver->getParameter('content.ttl_cache');
         if ($isTtlCacheEnabled && !$response->headers->hasCacheControlDirective('s-maxage')) {
-            $response->setSharedMaxAge($this->configResolver->getParameter('content.default_ttl'));
+            $response->setSharedMaxAge((int) $this->configResolver->getParameter('content.default_ttl'));
         }
     }
 }
diff --git a/eZ/Publish/Core/IO/Adapter/LocalAdapter.php b/eZ/Publish/Core/IO/Adapter/LocalAdapter.php
@@ -18,7 +18,7 @@
 /**
  * @internal
  */
-class LocalAdapter extends Local implements ConfigScopeChangeSubscriber
+final class LocalAdapter extends Local implements ConfigScopeChangeSubscriber
 {
     /** @var \eZ\Publish\Core\IO\IOConfigProvider */
     private $ioConfigProvider;

diff --git a/eZ/Publish/Core/IO/IOBinarydataHandler/SiteAccessDependentBinaryDataHandler.php b/eZ/Publish/Core/IO/IOBinarydataHandler/SiteAccessDependentBinaryDataHandler.php
@@ -14,7 +14,7 @@
 /**
  * @internal
  */
-class SiteAccessDependentBinaryDataHandler implements IOBinaryDataHandler
+final class SiteAccessDependentBinaryDataHandler implements IOBinaryDataHandler
 {
     /** @var \eZ\Publish\Core\MVC\ConfigResolverInterface */
     private $configResolver;

diff --git a/eZ/Publish/Core/IO/IOBinarydataHandler/SiteAccessDependentMetadataHandler.php b/eZ/Publish/Core/IO/IOBinarydataHandler/SiteAccessDependentMetadataHandler.php
@@ -14,7 +14,7 @@
 /**
  * @internal
  */
-class SiteAccessDependentMetadataHandler implements IOMetadataHandler
+final class SiteAccessDependentMetadataHandler implements IOMetadataHandler
 {
     /** @var \eZ\Publish\Core\MVC\ConfigResolverInterface */
     private $configResolver;

diff --git a/eZ/Publish/Core/MVC/Symfony/Templating/Twig/FieldBlockRenderer.php b/eZ/Publish/Core/MVC/Symfony/Templating/Twig/FieldBlockRenderer.php
@@ -313,9 +313,7 @@ private function getRenderFieldDefinitionBlockName($fieldTypeIdentifier, $type):
     }
 
     /**
-     * @param string $resourceType
-     *
-     * @return array
+     * @return array|\Twig\Template[]
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException
      */

diff --git a/eZ/Publish/Core/MVC/Symfony/Templating/Twig/ResourceProvider.php b/eZ/Publish/Core/MVC/Symfony/Templating/Twig/ResourceProvider.php
@@ -13,7 +13,7 @@
 /**
  * @internal
  */
-class ResourceProvider implements ResourceProviderInterface
+final class ResourceProvider implements ResourceProviderInterface
 {
     /** @var \eZ\Publish\Core\MVC\ConfigResolverInterface */
     private $configResolver;