-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-31912: Fixed decorating image URLs with proper absolute prefix #110
Conversation
The incorrect setting was used.
f36db28
to
b2e326e
Compare
@ezsystems/documentation-team qualification of "doc needed" changed, but I got you covered there ;) |
eZ/Bundle/EzPublishIOBundle/Tests/DependencyInjection/EzPublishIOExtensionTest.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Wójs <adam.wojs@ez.no>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retested successfully with single and multi repo setup using io.url_prefix.
Tested on eZ Platform EE v3.1.2 with diff.
v3.1
+This PR fixes decorating image URLs with custom
url_prefix
.While the JIRA ticket describes complicated AWS case, in fact URL prefix can be used with local (default) binary handler and it was the part which was broken.
In 2.5 we used to fetch
io.url_prefix
from dynamic (SiteAccess-aware) configuration for AbsolutePrefix which decorates media URLs.Since dynamic settings feature was no longer possible due to Symfony 4+ Container changes, we've rewritten the decorating to make the implementation fetch the proper setting.
It seems however that what should be used at the line above is actually
getUrlPrefix
instead ofgetLegacyUrlPrefix
. See the parameter names fetched by both methods.TODO:
Checklist:
$ composer fix-cs
).