Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed timezone for ezdate field from tests #187

Merged
merged 2 commits into from
May 24, 2021
Merged

removed timezone for ezdate field from tests #187

merged 2 commits into from
May 24, 2021

Conversation

mateuszdebinski
Copy link
Contributor

@mateuszdebinski mateuszdebinski commented May 24, 2021 •
edited
Loading

Question Answer
JIRA issue IBX-415
Type bug
Target eZ Platform version v3.2+
BC breaks no
Doc needed no

I ran locally tests for SOLR on eZ/Publish/API/Repository/Tests/SearchService/ dir with different time zones and all of them passed
Also, I restarted the test for SOLR in Travis 4-5 times and always test passed

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mateuszdebinski mateuszdebinski requested a review from a team May 24, 2021 12:44
@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels May 24, 2021
@mateuszdebinski mateuszdebinski marked this pull request as ready for review May 24, 2021 12:44
@adamwojs adamwojs requested a review from a team May 24, 2021 12:49
@Steveb-p Steveb-p requested a review from a team May 24, 2021 13:34
@adamwojs adamwojs merged commit ff1fa22 into 1.2 May 24, 2021
@adamwojs adamwojs deleted the correct-test-dateRangeAggregation branch May 24, 2021 18:58
@adamwojs
Copy link
Member

Could you please merge up changes @mateuszdebinski?

@mateuszdebinski
Copy link
Contributor Author

Done

@Steveb-p Steveb-p mentioned this pull request Jul 21, 2021
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mateuszdebinski @adamwojs @Steveb-p