EZP-31300: Refactored URL Search GW and handlers to rely on Doctrine #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactored URL Search gateway and criteria handlers to rely on Doctrine Connection and Query Builder instead eZc Database Handler
alongosz
added
Improvement
alongosz
requested review from
adamwojs,
mikadamczyk,
Nattfarinn,
webhdx,
ViniTou,
michal-myszka and
a team
alongosz
added a commit
that referenced
this pull request
Mar 29, 2020
…22) Squashed commit of the following: commit 9b9c5bd Author: Andrew Longosz <alongosz@users.noreply.github.com> Date: Mon Mar 30 01:05:33 2020 +0200 EZP-31300: [Doc] Documented breaking changes commit 5946c1c Author: Andrew Longosz <alongosz@users.noreply.github.com> Date: Mon Mar 30 00:58:24 2020 +0200 EZP-31300: [Tests] Aligned tests related to URL Search commit 43a84f7 Author: Andrew Longosz <alongosz@users.noreply.github.com> Date: Mon Mar 30 00:50:52 2020 +0200 EZP-31300: Refactored URL Search GW and handlers to rely on Doctrine * Refactored URL Search gateway and criteria handlers to rely on Doctrine Connection and Query Builder instead eZc Database Handler
ViniTou
approved these changes
Mar 30, 2020
lserwatka
approved these changes
Mar 30, 2020
adamwojs
reviewed
Mar 30, 2020
eZ/Publish/Core/Persistence/Legacy/URL/Query/CriterionHandler/Base.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Legacy/URL/Query/CriterionHandler/Base.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Legacy/URL/Query/CriterionHandler/Base.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Legacy/URL/Query/CriterionHandler/MatchNone.php
Outdated
Show resolved
Hide resolved
micszo
approved these changes
Mar 31, 2020
|
FYI @ezsystems/documentation-team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.0This PR replaces usages of eZc
DatabaseHandlerwith DoctrineConnectionandQueryBuilderin URL Search Gateway and Criteria handlers. The alignment of tests is separated from production code changes for the Reviewers convenience.Note that only some changes to code style and strict types are applied. They're out of scope anyway and, when it comes to strict types, too risky to be handled now, before final.
For the overview of package-wide changes related to the subject see #11
Doc:
Please see
doc/bc/changes-1.0.md(9b9c5bd) in this PRChecklist:
$ composer fix-cs).