IBX-1784: Added getDefaultLanguageCode method to API/Repository/Values/Content/Content #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Failed SonarCloud Code Analysis tests is a false positive for me. |
alongosz
requested changes
Jan 18, 2022
There was a problem hiding this comment.
We're missing test coverage here. Integration one would be enough. , but let's resolve ezsystems/ezplatform-http-cache#166 (review) first.
mateuszbieniek
changed the title
|
CS test fail looks like a false positive. |
alongosz
requested changes
Jan 20, 2022
eZ/Publish/API/Repository/Tests/Values/Content/DefaultLanguageCodeForContentTest.php
Outdated
Show resolved
Hide resolved
eZ/Publish/API/Repository/Tests/Values/Content/DefaultLanguageCodeForContentTest.php
Outdated
Show resolved
Hide resolved
eZ/Publish/API/Repository/Tests/Values/Content/DefaultLanguageCodeForContentTest.php
Outdated
Show resolved
Hide resolved
alongosz
requested changes
Jan 21, 2022
tests/lib/Repository/Values/Content/DefaultLanguageCodeForContentTest.php
Outdated
Show resolved
Hide resolved
alongosz
approved these changes
Jan 21, 2022
adamwojs
approved these changes
Jan 21, 2022
ViniTou
approved these changes
Jan 21, 2022
|
SonarCloud Quality Gate failed.
|
mnocon
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kernel side changes for ezsystems/ezplatform-http-cache#166