EZP-30543: Removed Dynamic Settings functionality from kernel #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webhdx
force-pushed
the
remove_dynamic_settings
branch
from
5eba974 to
772b0c9
Compare
webhdx
force-pushed
the
remove_dynamic_settings
branch
from
772b0c9 to
4553eac
Compare
webhdx
requested review from
alongosz,
adamwojs,
Nattfarinn,
lserwatka,
michal-myszka,
micszo,
mikadamczyk and
ViniTou
webhdx
changed the title
Nattfarinn
reviewed
Apr 1, 2020
eZ/Bundle/EzPublishCoreBundle/DependencyInjection/EzPublishCoreExtension.php
Outdated
Show resolved
Hide resolved
michal-myszka
suggested changes
Apr 1, 2020
| /** | ||
| * @return \eZ\Publish\Core\MVC\ConfigResolverInterface|\PHPUnit\Framework\MockObject\MockObject | ||
| */ | ||
| protected function mockConfigResolver(): ConfigResolverInterface |
There was a problem hiding this comment.
Suggested change
| protected function mockConfigResolver(): ConfigResolverInterface | |
| private function mockConfigResolver(): ConfigResolverInterface |
eZ/Bundle/EzPublishCoreBundle/URLChecker/Handler/AbstractConfigResolverBasedURLHandler.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/MVC/Symfony/Templating/Twig/FieldBlockRenderer.php
Outdated
Show resolved
Hide resolved
|
Behat tests failed: |
webhdx
changed the title
alongosz
requested changes
Apr 1, 2020
eZ/Bundle/EzPublishCoreBundle/URLChecker/Handler/AbstractConfigResolverBasedURLHandler.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/IO/IOBinarydataHandler/SiteAccessDependentMetadataHandler.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/IO/IOBinarydataHandler/SiteAccessDependentMetadataHandler.php
Show resolved
Hide resolved
eZ/Publish/Core/MVC/Symfony/Templating/Twig/FieldBlockRenderer.php
Outdated
Show resolved
Hide resolved
|
Closed in favor of #35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.0I removed Dynamic Settings (functionality allowing to inject
$my_param$parameters resolved in current scope) as this was already broken after Symfony 4 migration.One thing that I left is
ComplexSettingParser- this allows to resolve configuration using dynamic settings i.e. IO using'%webroot_dir%/$var_dir$/$storage_dir$values because those are injected as strings and resolved on demand insideOptionsProvider.Checklist:
$ composer fix-cs).