Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31542: Added PHP 7.4 support (eZ Platform 3.0) #37

Merged
merged 4 commits into from
Apr 24, 2020
Merged

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Apr 5, 2020

Question Answer
JIRA issue EZP-31542
Type improvement
BC breaks no
Tests pass yes
Doc needed no

The most significant changes from our perspective:

Trying to use values of type null, bool, int, float or resource as an array (such as $null["key"]) will now generate a notice. This does not affect array accesses performed by list(). RFC: https://wiki.php.net/rfc/notice-for-non-valid-array-container
Passing invalid characters to ''base_convert()'', ''bindec()'', ''octdec()'' and ''hexdec()'' will now generate a deprecation notice. The result will still be computed as if the invalid characters did not exist. Leading and trailing whitespace, as well as prefixes of type 0x (depending on base) continue to be allowed.
Throwing exceptions from __toString() is now permitted. Previously this resulted in a fatal error. Existing recoverable fatals in string conversions have been converted to Error exceptions. RFC: https://wiki.php.net/rfc/tostring_exceptions

Full upgrade notes: https://github.com/php/php-src/blob/PHP-7.4.5/UPGRADING

Checklist:

  • PR description is updated.
  • Tests are implemented.
  • Added code follows Coding Standards (use $ composer fix-cs).
  • PR is ready for a review.

.travis.yml Outdated Show resolved Hide resolved
@adamwojs adamwojs changed the title EZP-31542: Added PHP 7.4 support EZP-31542: Added PHP 7.4 support (eZ Platform 3.0) Apr 9, 2020
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be a merge up from ezsystems/ezpublish-kernel#3017
Nitpick (not sure to which PR applies):

eZ/Publish/Core/FieldType/Relation/Type.php Show resolved Hide resolved
@adamwojs adamwojs changed the base branch from master to 1.0 April 17, 2020 19:13
@adamwojs adamwojs requested a review from alongosz April 21, 2020 18:49
@micszo micszo self-assigned this Apr 22, 2020
@adamwojs adamwojs force-pushed the php74_support branch 2 times, most recently from cf9111e to 380db64 Compare April 23, 2020 10:04
@micszo micszo removed their assignment Apr 24, 2020
…in \eZ\Publish\Core\FieldType\Tests\UserTest::testValidate
@alongosz alongosz added the Fast-forward merge PR should be merged in a fast-forward way label Apr 24, 2020
@adamwojs adamwojs merged commit 3c4212e into 1.0 Apr 24, 2020
@adamwojs adamwojs deleted the php74_support branch December 6, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fast-forward merge PR should be merged in a fast-forward way Improvement Changes not fixing or changing behavior Rebase required
Development

Successfully merging this pull request may close these issues.

5 participants