IBX-6773: Bookmarks for non accessible contents cause exception #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidarl
force-pushed
the
IBX-6773_Bookmarks_for_non-accessible_contents_cause_exception
branch
2 times, most recently
from
a15afa0
to
7246b2e
Compare
vidarl
commented
May 30, 2024
vidarl
force-pushed
the
IBX-6773_Bookmarks_for_non-accessible_contents_cause_exception
branch
from
e2d1c9a
to
ddca556
Compare
ViniTou
requested changes
Jun 13, 2024
eZ/Publish/API/Repository/Values/Content/Query/Criterion/IsBookmarked.php
Outdated
Show resolved
Hide resolved
Steveb-p
reviewed
Jun 13, 2024
.../Persistence/Legacy/Tests/Filter/CriterionQueryBuilder/Location/BookmarkQueryBuilderTest.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Legacy/Bookmark/Gateway/ExceptionConversion.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Legacy/Bookmark/Gateway/ExceptionConversion.php
Outdated
Show resolved
Hide resolved
eZ/Publish/API/Repository/Values/Content/Query/SortClause/BookmarkId.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co>
…n - removed covers
…n - Changed to ibexa namespace for new classes
…xception - Changed to ibexa namespace for new classes
…xception - Changed to ibexa namespace for new classes
…xception - changed deprecations messages
Steveb-p
changed the title
Steveb-p
reviewed
Jun 27, 2024
Comment on lines
1990
to
1996
| $expectedIdsAfter = array_map(static function (Location $item) use ($demoDesignLocationId, $contactUsLocationId) { | ||
| if ($item->id === $demoDesignLocationId) { | ||
| return $contactUsLocationId; | ||
| } | ||
|
|
||
| return $item->id; | ||
| }, $beforeSwap->items); |
There was a problem hiding this comment.
Why is this mapping necessary? In particular, why is there a special case for $demoDesignLocationId + $contactUsLocationId?
There was a problem hiding this comment.
The mapping is no longer needed. In first version of PR, I did not implement SortClause\BookmarkId, so order of the result needed to be normalized.
I will revert the mapping.
I think the test is better when adding $contactUsLocation. In original test we test the edge case where two bookmarked locations are swapped... In my version of the test, only one of the locations that are swapped are bookmarked.
Edit: Fixed cut&paste error that made the second paragraph meaningless
|
Steveb-p
reviewed
Sep 9, 2024
…n - Added logger in BookmarkService
…xception - Added logger in BookmarkService
Steveb-p
approved these changes
Nov 8, 2024
konradoboza
reviewed
Nov 8, 2024
src/contracts/Repository/Values/Content/Query/Criterion/IsBookmarked.php
Show resolved
Hide resolved
src/contracts/Repository/Values/Content/Query/Criterion/IsBookmarked.php
Outdated
Show resolved
Hide resolved
src/contracts/Repository/Values/Content/Query/Criterion/IsBookmarked.php
Outdated
Show resolved
Hide resolved
src/contracts/Repository/Values/Content/Query/SortClause/BookmarkId.php
Outdated
Show resolved
Hide resolved
src/contracts/Repository/Values/Content/Query/SortClause/BookmarkId.php
Outdated
Show resolved
Hide resolved
src/lib/Persistence/Legacy/Filter/SortClauseQueryBuilder/Bookmark/IdSortClauseQueryBuilder.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co> Co-authored-by: Konrad Oboza <konrad.oboza@ibexa.co>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3If user bookmark some location which he later looses access too, then the bookmark list in admin-ui fails with an exception.
Simply fixing
BookmarkService::loadBookmarks()would be easy. The problem is to implementcountUserBookmarks()in persistence layer and having it taking into account user permissions so that BC would be kept.Talked with Adam on how to solve this without breaking BC and he suggested implementing it using filtering
The Bookmark filter will only work with location filtering (
LocationService::find()), not with content (ContentService::find())Checklist:
$ composer fix-cs).@ezsystems/engineering-team).