Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31698: Removed ConfigResolverCleanup cache warmer #79

Merged
merged 1 commit into from
Jun 23, 2020
Merged

EZP-31698: Removed ConfigResolverCleanup cache warmer #79

merged 1 commit into from
Jun 23, 2020

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Jun 22, 2020

Question Answer
JIRA issue EZP-31698
Type bug
Target eZ Platform version v3.0
BC breaks no
Tests pass yes
Doc needed no

Symfony 4/5 no longer allows to set services after they've been initialized.

Checklist:

  • PR description is updated.
  • PR is ready for a review.

@webhdx webhdx added Bug Something isn't working Ready for review labels Jun 22, 2020
@webhdx webhdx self-assigned this Jun 22, 2020
alongosz
alongosz approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA: regression tests against EZP-25098 would be good.

@micszo micszo self-assigned this Jun 23, 2020
@webhdx webhdx force-pushed the removed_config_resolver_cleanup branch from fb078f9 to 30d7203 Compare June 23, 2020 08:49
@webhdx webhdx force-pushed the removed_config_resolver_cleanup branch from 30d7203 to 310f885 Compare June 23, 2020 09:01
micszo
micszo approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE v3.0.5 with diff.
Also tested in scope of https://jira.ez.no/browse/EZP-25098.

@micszo micszo removed their assignment Jun 23, 2020
@lserwatka lserwatka merged commit 4448add into ezsystems:1.0 Jun 23, 2020
Steveb-p pushed a commit that referenced this pull request May 31, 2022
@adamwojs
Dropped Travis CI / AppVeyor configuration in favor of GitHub Actions (…
14c7f5c 
…#79)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micszo micszo micszo approved these changes

@alongosz alongosz alongosz approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@webhdx webhdx

Labels
Bug Something isn't working QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@webhdx @adamwojs @alongosz @micszo @lserwatka