Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31342: Added argument to service, to use valid database connection #31

Merged
merged 1 commit into from
Jan 31, 2020
Merged

EZP-31342: Added argument to service, to use valid database connection #31

merged 1 commit into from
Jan 31, 2020

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
Tickets EZP-31342
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Jan 30, 2020
@micszo micszo self-assigned this Jan 31, 2020
micszo
micszo approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE v2.5.8 with diff with multi db setup.

@micszo micszo removed their assignment Jan 31, 2020
@lserwatka lserwatka merged commit ea183a3 into ezsystems:1.0 Jan 31, 2020
@lserwatka
Copy link
Member

could you merge it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@micszo micszo micszo approved these changes

@adamwojs adamwojs adamwojs approved these changes

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

Assignees
No one assigned
Labels
Bug Something isn't working QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mateuszdebinski @lserwatka @adamwojs @micszo @konradoboza