EZP-30222: Handled tables copied from external sources

[konradoboza]

Question	Answer
JIRA issue	EZP-30222
Bug/Improvement	yes
New feature	no
Target version	1.1, master
BC breaks	no
Tests pass	yes
Doc needed	no

This PR introduces a slightly different way of handling table width:

• introducing normalizeWidth function which handles px and pt units as these are the main ones used in tables,
• rounding width values, e.g. 110.5pt,
• taking style="border: [thickness] [style] [color];" property from CSS into account and applying border="1px" to make things consistent with the tables generated by RTE by default.

TODO:

• Implement feature / fix a bug.
• Implement tests.
• Fix new code according to Coding Standards ($ composer fix-cs).
• Ask for Code Review.

[alongosz]

Test case for output is missing, not sure why we have them in lossy folder anyway. It feels output testing is needed here as it should be straightforward. Correct me if I'm wrong.

POV ping @dew326 can we indeed normalize pt to px as pt*1.33 = px or should we actually store units in DocBook as well?

[konradoboza]

@alongosz that would be correct but we are actually "losing" some data here:

• value style="border: 1px solid #000;" is converted to the default border="1" and lost as we don't handle border styling,
• value for width inpt, as we convert and normalize it to px to not change prior behavior.

[alongosz]

@alongosz that would be correct but we are actually "losing" some data here:

• value style="border: 1px solid #000;" is converted to the default border="1" and lost as we don't handle border styling,

Ok, that makes sense. Still, can we see a test case for output (X)HTML?

• value for width inpt, as we convert and normalize it to px to not change prior behavior.

We can indeed keep the normalization as-is right now.

[alongosz]

Internal sync: output testing for lossy cases is not possible.

[andrerom]

+1

But is there coverage for:

• Handling % unit?
• Making sure units like em is still not stored in the backend format?

[konradoboza]

I added some more robust handling of not supported units (others than px, pt, %) to make the whole solution a bit more bulletproof. Also, simplified rounding units as round function does casting to number by default. @andrerom @alongosz please take another look.

[alongosz]

🏆 for DRY in XSLT

[andrerom]

Nice 👍 Indeed 🏅 for DRY here!

[micszo]

Works fine now!
QA Approved on eZ Platform EE v2.5.8 with diff.