Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZEE-3094: Added missing int casting in the RelationProcessor::getRelatedObjectIds #138

Merged
merged 1 commit into from
Apr 10, 2020
Merged

EZEE-3094: Added missing int casting in the RelationProcessor::getRelatedObjectIds #138

merged 1 commit into from
Apr 10, 2020

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Apr 9, 2020

Question Answer
JIRA issue EZEE-3094
Bug/Improvement yes
New feature no
Target version master
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs added the Bug Something isn't working label Apr 9, 2020
@adamwojs adamwojs requested a review from a team April 9, 2020 15:54
@adamwojs adamwojs self-assigned this Apr 9, 2020
alongosz
alongosz approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve the PR/commit title so it reflects the change, not the cause (especially that it relates to EE package which is not important, nor available to everyone)

@micszo micszo self-assigned this Apr 10, 2020
micszo
micszo approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE v3.0.0 with diff.

@micszo micszo removed their assignment Apr 10, 2020
@adamwojs adamwojs changed the title EZEE-3094: Internal links in RichText blocks crash page builder on save EZEE-3094: Added missing int casting in the RelationProcessor::getRelatedObjectIds Apr 10, 2020
@adamwojs
Copy link
Member Author

adamwojs commented Apr 10, 2020 •
edited
Loading

PR updated according to code review suggestions (no code changes, improved the PR/commit title).

@adamwojs adamwojs merged commit 81a5050 into master Apr 10, 2020
@adamwojs adamwojs deleted the ezee_3094 branch April 10, 2020 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micszo micszo micszo approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@adamwojs adamwojs

Labels
Bug Something isn't working QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamwojs @alongosz @micszo