EZP-30861: Handled line breaks inside headings #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
reviewed
Apr 17, 2020
alongosz
requested changes
Apr 17, 2020
src/lib/eZ/RichText/Resources/stylesheets/xhtml5/edit/docbook.xsl
Outdated
Show resolved
Hide resolved
…eparated breakline templates depending on the use-case
alongosz
approved these changes
Apr 23, 2020
konradoboza
requested review from
andrerom and
adamwojs
and removed request for
adamwojs
andrerom
approved these changes
Apr 27, 2020
bogusez
approved these changes
Apr 27, 2020
|
Could you merge it up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.1,2.0,masterCurrently, there is another inconsistent scenario when line breaks appear inside headings (
<h1> - <h6>). Asliterallayouttag responsible for correctly displaying breaklines cannot be placed inside<title>tag (according to DocBook schema), I adjusteddocbook.rngto reflect this case. Asdb.all.inlinesrules are used in many places, I decided to addliterallayoutonly totitleelement to avoid potential issues. XSL logic is basically about reusing existing rules for the paragraph - we don't want to addliterallayouttotitlewhen there are no line breaks, so those scenarios are left untouched.TODO:
$ composer fix-cs).