EZP-31127: Skipped non-existing Content Types in ContentTypeIdentifier criterion #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
changed the title
4 tasks
andrerom
approved these changes
Jan 15, 2020
adamwojs
approved these changes
Jan 16, 2020
alongosz
changed the title
alongosz
approved these changes
Jan 16, 2020
andrerom
reviewed
Jan 16, 2020
|
Will you add warning logging here as well like kernel? |
|
@andrerom Done. |
Co-Authored-By: André R. <andre.romcke@gmail.com>
micszo
requested changes
Jan 23, 2020
There was a problem hiding this comment.
The following query
//use eZ\Publish\API\Repository\Values\Content\Query;
// @var \eZ\Publish\API\Repository\SearchService $searchService
$query = new Query();
$query->query = new Query\Criterion\ContentTypeIdentifier(
['folder']
);
$results = $searchService->findContent($query);
stops working with the changes from this PR - 0 results (without it returns e.g. eZ Platform folder on clean install).
Tested on eZ Platform EE 2.5 with Solr 6.6.5.
|
@micszo I'll look into it. |
|
@micszo I've pushed the fix. Please test again! |
alongosz
approved these changes
Jan 30, 2020
micszo
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
Tested with ezsystems/ezpublish-kernel#2872.
The previous issue with Solr is resolved. 👍
|
@alongosz could you merge it up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variant of ezsystems/ezpublish-kernel#2872 PR for Solr