Upgraded package to be compatible with eZ Platform v3.0 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Delegated importing test fixtures to eZ Platform Kernel FixtureImporter. * Replaced usages of eZc Database Handler with Doctrine Connection. * Aligned CS to follow eZ Platform Code Style.
ContextErrorException was dropped in Symfony 4.0 in favor of the native \ErrorException
andrerom
approved these changes
Apr 7, 2020
|
@alongosz Proposed additions to README to specify support limitations |
michal-myszka
approved these changes
Apr 7, 2020
+1 |
vidarl
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes outstanding issues discovered by CI and upgrades code and test setup to be compatible with eZ Platform v3.0.
I recommend fast-forward merge because the PR contains out of scope fix for EZP-31512 (see ezsystems/ezplatform-richtext#128 for details).
I've upgraded test setup not to rely on dropped eZc Database Handler and while at it updated code to rely on Doctrine instead of PDO (
PDO::FETCH_*usages). Using PDO constants in relevant changed places is deprecated in Doctrine.There was also one outstanding change - Symfony
ContextErrorExceptionhas been dropped in Symfony 4.0 in favor of native\ErrorException.TODO:
$ composer fix-cs).