EZP-26834: Synchronize translations in ezplatform-i18n #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunogier
approved these changes
Jan 16, 2017
| rm ./vendor/ezsystems/ezplatform-i18n/ezpublish-kernel/*.xlf | ||
| rm ./vendor/ezsystems/ezplatform-i18n/repository-forms/*.xlf | ||
|
|
||
| echo '# Miror the translation files'; |
| @@ -48,7 +48,8 @@ | |||
| "behat/mink-goutte-driver": "*", | |||
| "behat/mink-selenium2-driver": "*", | |||
| "jarnaiz/behat-junit-formatter": "^1.3", | |||
| "ezsystems/behatbundle": "^6.3" | |||
| "ezsystems/behatbundle": "^6.3", | |||
| "ezsystems/ezplatform-i18n": "^1.0@dev" | |||
There was a problem hiding this comment.
Could you move the new requirement to another line ? We did say that we would try to avoid generating conflicts for users, and the last line of require or require-dev is a good place to start from :)
I'd move it either in first position, or around the top.
| @@ -0,0 +1,21 @@ | |||
| #!/usr/bin/env sh | |||
| # This script should be used to synchronize ezplatform-i18n repository | |||
| # Translations should be extracted in each bundles before this step | |||
There was a problem hiding this comment.
I'd replace this with "Translations must be up-to-date in all packages".
Since translations are supposed to be update in pull-requests, they should always be up-to-date ;)
nicolas-bastien
force-pushed
the
EZP-26834-ezplatform-i18n-synchronization
branch
from
f7d8e1e to
a68dde6
Compare
andrerom
pushed a commit
that referenced
this pull request
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira : https://jira.ez.no/browse/EZP-26834
Description
This PR adds a script to ease translation synchronisation to ezplatform-i18n