EZP-31377: Use imagick by default on Platform.sh to avoid memory issues

[andrerom]

Question	Answer
JIRA issue	EZP-31377
Bug/Improvement	yes
New feature	no
Target version	2.5
BC breaks	no
Tests pass	N/A
Doc needed	no

GD uses PHP memory and hence it's better if we can use imagick if it's available to avoid risking running into php memory issues on larger images.

TODO:

• Implement feature / fix a bug.
• Implement tests.
• Fix new code according to Coding Standards ($ composer fix-cs).
• Ask for Code Review.

[vidarl]

Sorry, I have second thoughts about my approval here.

We already have configuration for imagemagick in ezplatform.yml:

ezpublish:
    imagemagick:
        enabled: true
        path: /usr/bin/convert

I think we should use that ( currently not used/refered to at all in meta repo), instead of setting the liip_imagine.driver parameter directly

[andrerom]

@vidarl On closer look those settings have been deprecated since 5.4:

• https://github.com/ezsystems/ezpublish-kernel/blob/0eed2fe2d8e4f531bb1fc811a32cc54b90a2e7f4/eZ/Bundle/EzPublishCoreBundle/DependencyInjection/Configuration.php#L299-L308
• https://github.com/ezsystems/ezpublish-kernel/blob/c849ef16ba5aecb786f61267855e24a5cf62bcf6/eZ/Bundle/EzPublishCoreBundle/DependencyInjection/Configuration/Parser/Image.php#L40
• https://github.com/ezsystems/ezpublish-kernel/blob/d4542d36e30022067f788ba6654984851cfb2ef2/eZ/Bundle/EzPublishCoreBundle/Resources/config/default_settings.yml#L171

What made you think this should be used? Are there some doc still referring to it that should be fixed?

[vidarl]

I was made aware of these settings when working on a migration. Was not aware that they were only used for interjecting into legacy. Your PR looks good then

[andrerom]

Ready for testing again then @micszo

[damianz5]

I'm still verifying it but looks like there is no parameter liip_imagine.driver in
php bin/console debug:container --parameters --env=dev | grep liip_imagine
similar parameter is liip_imagine.driver_service -> liip_imagine.gd, but its resolved from config, not parameters

ref https://github.com/liip/LiipImagineBundle/blob/88775aaa5f208885c3486d34d0360486262c50f3/DependencyInjection/LiipImagineExtension.php#L102

[andrerom]

@damianz5 Ok, do you see a way we can set it dynamically then?

[damianz5]

Updated - ready for retest

[andrerom]

Thanks @damianz5 👍 👍

PS: I took the liberty of removing the dot in the param name now to make to more clear it's global param.

Status: Ready for QA now

[micszo]

Retested successfully.