-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-31519: Moved app.php rejection snippet from front controller to ezpublish-kernel #514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On nginx/apache this regex blocks paths like:
http://example.com/app.php
http://example.com/TestFolder1/app.php
(where TestFolder1 and TestFolder2 are existing Content Items)
But fails to block (homepage is displayed instead):
http://example.com/TestFolder1/TestFolder2/app.php
http://example.com/app.phprandom
Writing it here as I'm not sure what's supposed to be blocked, maybe this kind of URLs should be rejected as well.
As I recall, this is as intended. The point is to block all direct access to app.php, while not blocking content named |
I just moved the logic from EZP-30716. If this should be changed then we need new ticket and this should be done after 3.0 release as this is the highest priority at the moment. I need this to be merged in order to merge it up to ping @lserwatka
|
@mnocon Can I get final approval from you? We need to merge it. |
I've changed the rule in
vhost.template
files in order to unify logic in both places. This way we can block some requests on httpd level.Rejection logic has been moved to: ezsystems/ezpublish-kernel#3010