Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added conflict with doctrine/dbal >= 2.11.0 #600

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Added conflict with doctrine/dbal >= 2.11.0 #600

merged 1 commit into from
Oct 5, 2020

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Oct 2, 2020 •
edited
Loading

JIRA: -

Description

Added conflict with doctrine/dbal >= 2.11.0 to unblock CI on 1.13 branch:

install_app_1_1a889336cc0b | > Incenteev\ParameterHandler\ScriptHandler::buildParameters
install_app_1_1a889336cc0b | Creating the "app/config/parameters.yml" file
install_app_1_1a889336cc0b | > Sensio\Bundle\DistributionBundle\Composer\ScriptHandler::buildBootstrap
install_app_1_1a889336cc0b | > eZ\Bundle\EzPublishCoreBundle\Composer\ScriptHandler::clearCache
install_app_1_1a889336cc0b | 
install_app_1_1a889336cc0b |                                                         
install_app_1_1a889336cc0b |   [Symfony\Component\Console\Exception\LogicException]  
install_app_1_1a889336cc0b |   An option named "connection" already exists.          
install_app_1_1a889336cc0b |                                                         
install_app_1_1a889336cc0b | 
install_app_1_1a889336cc0b | Script eZ\Bundle\EzPublishCoreBundle\Composer\ScriptHandler::clearCache handling the symfony-scripts event terminated with an exception
install_app_1_1a889336cc0b | 
install_app_1_1a889336cc0b |                                                                              
install_app_1_1a889336cc0b |   [RuntimeException]                                                         
install_app_1_1a889336cc0b |   An error occurred when executing the "'cache:clear --no-warmup'" command:  
install_app_1_1a889336cc0b |                                                                              
install_app_1_1a889336cc0b |                                                                              
install_app_1_1a889336cc0b |                                                                              
install_app_1_1a889336cc0b |                                                                              
install_app_1_1a889336cc0b |                                                                              
install_app_1_1a889336cc0b |     [Symfony\Component\Console\Exception\LogicException]                     
install_app_1_1a889336cc0b |     An option named "connection" already exists.                             
install_app_1_1a889336cc0b |                                                                              
install_app_1_1a889336cc0b | 
install_app_1_1a889336cc0b | install [--prefer-source] [--prefer-dist] [--dry-run] [--dev] [--no-dev] [--no-custom-installers] [--no-autoloader] [--no-scripts] [--no-progress] [--no-suggest] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--ignore-platform-reqs] [--] [<packages>]...

Source build: https://travis-ci.org/github/ezsystems/ezplatform/jobs/731802629

Links:

@adamwojs adamwojs added the Bug label Oct 2, 2020
@adamwojs adamwojs self-assigned this Oct 2, 2020
micszo
micszo previously approved these changes Oct 2, 2020
View reviewed changes
alongosz
alongosz requested changes Oct 2, 2020
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@micszo micszo dismissed their stale review October 2, 2020 12:59

change can't be installed on PHP 5.6

@adamwojs adamwojs force-pushed the downgrade_doctrine_dbal branch from 4b9ad22 to 5346989 Compare October 2, 2020 13:12
@adamwojs
Copy link
Member Author

adamwojs commented Oct 2, 2020

PR updated according to @alongosz code review suggestions. Please wait for CI results.

@adamwojs adamwojs changed the title Downgraded "doctrine/dbal" to "2.10.4" Added conflict with doctrine/dbal >= 2.11.0 Oct 2, 2020
@micszo micszo requested a review from mnocon October 5, 2020 06:23
@adamwojs adamwojs merged commit 6bacb0f into 1.13 Oct 5, 2020
@adamwojs adamwojs deleted the downgrade_doctrine_dbal branch October 5, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micszo micszo micszo approved these changes

@mnocon mnocon mnocon approved these changes

@alongosz alongosz alongosz approved these changes

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@ViniTou ViniTou Awaiting requested review from ViniTou

Assignees

@adamwojs adamwojs

Labels
Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adamwojs @Nattfarinn @alongosz @mnocon @micszo @ViniTou