EZP-26071: Download asset binary only if we need to create a variation #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroze
force-pushed
the
performance/dont-download-binary-if-not-generating-variation
branch
from
b4c19d5 to
a3e3d6e
Compare
|
Big +1 (test failures do not seem related) |
|
+1 But we need Jira issue and it should point to stable branch 6.4 as we want to make sure this is included in 6.4.1, /cc @janit |
andrerom
changed the title
sroze
deleted the
performance/dont-download-binary-if-not-generating-variation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a major performance issue: it removes the need of any I/O (downloading the image binary) when simply
geting an image variation. As you probably know, this method is called at every render of theezfield_image.On a "normal" setup with the assets stored on the disk it's not so bad but when storing the assets in S3, we had up to 2 seconds and 60 requests to S3 per page view 😱