-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZEE-2661: Allowed translation filtering when publishing version #2615
EZEE-2661: Allowed translation filtering when publishing version #2615
Conversation
This really looks like a hack on top of a system that doesn't support versioning per translation. Because of that it comes with a number of weird edge cases. The first one that came to my mind - what happens when you edit a Content with 2 translations, you change the 1st translation but then proceed to publish the 2nd translation? It would be easy to implement this on top of the Public API. What is the reason for adding it here, instead of implementing it for example in the date-based publisher? The similar question goes for #2598 |
You will end with published version identical to that one without changes to 1st translation. Would you as a user expect different behavior?
To have consistent publish action across places. |
Not really, it's what I would expect, it's just that this adds another layer of meaning to the whole thing (publishing drafts/fields/translations). I guess it's a matter of how you approach the whole thing, I tend to think Repository should be made as simple and straightforward as possible, and specific behavior should be implemented on top of it. But it's not really my prerogative anymore, so in any case, thanks for the reply 👍 |
57ab79a
to
96f6ccd
Compare
Current status: |
@ViniTou could you look into this test results? |
9aa7806
to
49811ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on eZ Platform EE v2.5.1 together with the other 3 PRs.
The four test flows, as described below, work with these changes:
https://jira.ez.no/browse/EZP-29691
https://jira.ez.no/browse/EZP-29694
https://jira.ez.no/browse/EZP-29694?focusedCommentId=240646&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-240646
https://jira.ez.no/browse/EZEE-2661
7.5
(2.5.1
)As a part of fix, we decided to add possibility to publish specific translations only.
As it seems more clearer now, I have decided to move previous logic from Handler inside ContentService and resolve it on API level.
TODO:
$ composer fix-cs
).