EZP-30646: Reimplemented SignalSlots using EventDispatcher #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nattfarinn
changed the title
Merged
4 tasks
alongosz
changed the title
alongosz
requested changes
Jul 8, 2019
There was a problem hiding this comment.
As we've discussed multiple times, from now on, everything that is going either to be consumed or used by external and/or 3rd party packages, should be part of either API or SPI.
Seems to me that usage of Events is strictly for consumption, so it should have at least it's interface in API or be moved there entirely.
Applies to eZ/Publish/Core/Event/*/*Event.php
Other remarks:
eZ/Publish/Core/Search/Common/EventSubscriber/AbstractSearchEventSubscriber.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Search/Common/EventSubscriber/AbstractSearchEventSubscriber.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Search/Common/EventSubscriber/AbstractSearchEventSubscriber.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Search/Common/EventSubscriber/TrashEventSubscriber.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Search/Common/EventSubscriber/UserEventSubscriber.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Search/Common/EventSubscriber/AbstractSearchEventSubscriber.php
Show resolved
Hide resolved
4 tasks
4 tasks
alongosz
force-pushed
the
ezp-30646
branch
2 times, most recently
from
c3c2f34 to
bfb2299
Compare
alongosz
approved these changes
Jul 16, 2019
Nattfarinn
force-pushed
the
ezp-30616-follow-up
branch
from
b74676d to
40e8e42
Compare
Nattfarinn
force-pushed
the
ezp-30646
branch
2 times, most recently
from
188ef91 to
14ac703
Compare
* Dropped SignalSlot layer * Dropped ezpublish.api.signal Event * Reimplemented functions provided by slots using Event Subscribers * Aligned Repository factories * Aligned misc usages * Aligned tests Co-Authored-By: Adam Wójs <adamwojs@users.noreply.github.com>
mnocon
approved these changes
Aug 5, 2019
Nattfarinn
added a commit
that referenced
this pull request
Aug 5, 2019
* EZP-30646: Reimplemented SignalSlots using EventDispatcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterThis is not standalone PR
Depends on:
EZP-30616: Inherited Symfony Event instead of PSR #2712(Merged)EZP-30616: Reimplemented repositotry services using EventDispatcher instead of SignalDispatcher #2658(Merged)EZP-30616: Fixed missing parameter in PublishVersion Events #2684(Merged)Requires:
TODO:
$ composer fix-cs).masterafter EZP-30616: Inherited Symfony Event instead of PSR #2712 merge