[Behat] EZP-30884: Added support for class name as service id #2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnocon
changed the title
|
|
ViniTou
approved these changes
Sep 16, 2019
alongosz
approved these changes
Sep 16, 2019
|
@lserwatka this one can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regex, as part of EzSystemsBehatExtension, is responsible for splitting a string like:
injectService $argumentParser @EzSystems\BehatBundle\Helper\ArgumentParserinto three parts:
injectService$argumentParser@EzSystems\BehatBundle\Helper\ArgumentParserUnfortunely currently it works as:
injectService$argumentParser@EzSystemswhich makes it impossible to inject services using class name.
Usage: https://github.com/ezsystems/ezplatform-admin-ui/pull/1068/files#diff-1cc2fa436666ba5b8522af19a0efe93fR29
Merging upstream: this file has been removed in master, needs to be ported to BehatBundle for 3.0: https://github.com/ezsystems/BehatBundle/blob/master/src/lib/Core/Behat/AnnotationArgumentResolver.php#L73