-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored integration test for ContentService #2757
Conversation
9a41f26
to
37f3306
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mikadamczyk 🎉 This is very much needed refactoring.
Overall please see SonarLint analysis and address issues related to your changes, according to our internal sync. Also please restore dropped FQCN in PhpDocs.
Some specifics:
eZ/Publish/API/Repository/Tests/ContentServiceAuthorizationTest.php
Outdated
Show resolved
Hide resolved
6e95914
to
b1107e2
Compare
Just for info - tests were intentionally written in that style, because the idea was to extract the parts between BTW, the extraction script should still be somewhere in the repository. |
Thanks @pspanja for your input! I didn't know that :) |
Thank you for your explanation @pspanja :) |
b1107e2
to
d34fb71
Compare
No QA required - only integration test changes. Merging, thank you @mikadamczyk! |
7.5
This refactor is a result of working on ContentService and a need to add some new tests and change the old ones in https://jira.ez.no/browse/EZP-30427
TODO:
$ composer fix-cs
).