Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-30382: Add content hide/reveal to REST API #2767

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Sep 17, 2019

Question Answer
JIRA issue EZP-30382
Bug/Improvement yes
New feature yes
Target version 7.5
BC breaks no
Tests pass yes
Doc needed yes

This adds missing functionality on hide/reveal content via REST API.

When merging up this must be moved to new REST repository and only REST DOC file need to be merged up!

TODO:

  • Implement feature / fix a bug.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@ViniTou ViniTou force-pushed the EZP-303820-hide-reveal-content-rest branch from 0864832 to 973edb6 Compare September 17, 2019 08:58
@ViniTou ViniTou requested a review from alongosz September 17, 2019 08:58
@Nattfarinn
Copy link
Contributor

Great contribution! Thanks. Here, take this:
hqdefault

@mnocon mnocon self-assigned this Sep 24, 2019
Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lserwatka lserwatka merged commit baa0acf into 7.5 Sep 26, 2019
@lserwatka lserwatka deleted the EZP-303820-hide-reveal-content-rest branch September 26, 2019 08:46
@lserwatka
Copy link
Member

@ViniTou could you merge it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

8 participants