EZP-30621: Dropped deprecated LegacyStorage Gateways #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
requested review from
adamwojs,
mikadamczyk,
Nattfarinn,
pawbuj,
webhdx and
ViniTou
pawbuj
approved these changes
Oct 10, 2019
ViniTou
approved these changes
Oct 10, 2019
adamwojs
approved these changes
Oct 10, 2019
webhdx
approved these changes
Oct 10, 2019
mikadamczyk
approved these changes
Oct 10, 2019
|
Thanks for the reviews. Those classes were not used for quite some time so no QA required (sanities on external storage are included in FT integration tests). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master (8.0@dev)for eZ Platformv3.0The
LegacyStorageGateways were deprecated sincev6.11(eZ Platformv1.11) in favor ofDoctrineStorageGateways relying onDoctrine\DBAL\Connectioninstead of deprecated database handler originating from Zeta Components.Those classes refer to External Storage for core Field Types only.
This PR removes those unused classes completely.
TODO:
LegacyStorageclasses.$ composer fix-cs).