Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31026: Fixed resolving of lang params in SA loadContentListByContentInfo #2816

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Oct 10, 2019

Question Answer
JIRA issue EZP-31026
Bug/Improvement yes
New feature no
Target version 7.5, master
BC breaks no
Tests pass yes
Doc needed no

Issue discovered while working on #2786

Method \eZ\Publish\API\Repository\ContentService::loadContentListByContentInfo called from the site access aware layer doens't respect current siteaccess languages settings.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs added the Bug label Oct 10, 2019
@adamwojs adamwojs self-assigned this Oct 10, 2019
@adamwojs adamwojs changed the title EZP-31026: Auto resolving the language parameters in the eZ\Publish\Core\Repository\SiteAccessAware\ContentService::loadContentListByContentInfo EZP-31026: Auto resolving the language parameters in the SiteAccessAware\ContentService::loadContentListByContentInfo Oct 10, 2019
@andrerom
Copy link
Contributor

andrerom commented Oct 10, 2019

👍 You'll also need to update unit tests I think.

…entInfo

Fixed resolving of language parameters in the `SiteAccessAware\ContentService::loadContentListByContentInfo` method.
@adamwojs adamwojs changed the title EZP-31026: Auto resolving the language parameters in the SiteAccessAware\ContentService::loadContentListByContentInfo EZP-31026: Fixed resolving of lang params in SA loadContentListByContentInfo Oct 11, 2019
@adamwojs adamwojs merged commit 50d956c into 7.5 Oct 11, 2019
@adamwojs adamwojs deleted the ezp_31026 branch October 11, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants