Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31053: Prioritized languages should be respected by Content::getContentType #2833

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Oct 18, 2019

Question Answer
JIRA issue EZP-31053
Bug/Improvement yes
New feature no
Target version 7.5, master
BC breaks no
Tests pass yes
Doc needed no

Issue discovered while working on #2786

Method \eZ\Publish\Core\Repository\ContentService::internalLoadContent ignores language priority while loading content type.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.
  • Fix JIRA issue id in commit message before merge

eZ/Publish/Core/Repository/ContentService.php Outdated Show resolved Hide resolved
@adamwojs adamwojs changed the title EZP-30153: Prioritized languages should be respected by Content::getContentType EZP-31053: Prioritized languages should be respected by Content::getContentType Oct 21, 2019
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, nitpick:

eZ/Publish/API/Repository/Tests/ContentServiceTest.php Outdated Show resolved Hide resolved
…g content type in ContentService::internalLoadContent
@adamwojs
Copy link
Member Author

PR updated according to @ViniTou and @alongosz code review suggestions.

@adamwojs adamwojs merged commit ffc5d44 into 7.5 Oct 22, 2019
@adamwojs adamwojs deleted the ezp_31063 branch October 22, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants