Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31095: Introduced strict types for FieldTypeService #2853

Merged
merged 1 commit into from
Nov 7, 2019
Merged

EZP-31095: Introduced strict types for FieldTypeService #2853

merged 1 commit into from
Nov 7, 2019
+22 −21

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Nov 1, 2019 •
edited
Loading

Question Answer
JIRA issue EZP-31095
Bug/Improvement yes
New feature no
Target version master
BC breaks yes
Tests pass yes
Doc needed yes

This PR introduces strict types for the \eZ\Publish\API\Repository\FieldTypeService

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

Sorry, something went wrong.

@adamwojs adamwojs self-assigned this Nov 1, 2019
@adamwojs adamwojs merged commit 696301a into master Nov 7, 2019
@adamwojs adamwojs deleted the field_type_service_typehint branch November 7, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk

@mnocon mnocon

@ViniTou ViniTou

Assignees

@adamwojs adamwojs

Labels
DX Improvement QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adamwojs @mikadamczyk @mnocon @ViniTou