Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31125: Added TranslatedName to Content/ContentInfo in REST response #2885

Merged
merged 3 commits into from
Dec 12, 2019
Merged

EZP-31125: Added TranslatedName to Content/ContentInfo in REST response #2885

merged 3 commits into from
Dec 12, 2019

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Nov 26, 2019 •
edited
Loading

Question Answer
JIRA issue EZP-31125
Bug/Improvement yes
New feature no
Target version 7.x
BC breaks no
Tests pass ?
Doc needed no

Added TranslatedName property to Content/ContentInfo in REST response which contains content name translated according to current site access setting.

TODO:

@adamwojs adamwojs self-assigned this Nov 26, 2019
@adamwojs
Copy link
Member Author

PR updated according to @mikadamczyk code review suggestions.

alongosz
alongosz requested changes Nov 28, 2019
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please include REST spec update in this PR.

@adamwojs adamwojs mentioned this pull request Dec 2, 2019
Merged
3 tasks
@adamwojs adamwojs requested a review from alongosz December 2, 2019 12:53
micszo
micszo approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test status in https://github.com/ezsystems/ezplatform-page-builder/pull/438.

@adamwojs adamwojs merged commit 441ec54 into 7.5 Dec 12, 2019
@adamwojs adamwojs deleted the ezp_31125_translated_name_in_rest_response branch December 12, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@micszo micszo micszo approved these changes

@alongosz alongosz alongosz approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

Assignees

@adamwojs adamwojs

Labels
Improvement QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adamwojs @mikadamczyk @alongosz @micszo @ViniTou