EZP-31046: Improved ChainConfigResolver by extracting code to separate config resolvers #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikadamczyk
force-pushed
the
EZP-31046-chain-config-resolver
branch
from
a1f03cc to
c6a0d73
Compare
mikadamczyk
changed the title
alongosz
requested changes
Dec 13, 2019
...lishCoreBundle/DependencyInjection/Configuration/ConfigResolver/SiteAccessConfigResolver.php
Show resolved
Hide resolved
eZ/Bundle/EzPublishCoreBundle/DependencyInjection/EzPublishCoreExtension.php
Show resolved
Hide resolved
...shCoreBundle/DependencyInjection/Configuration/ConfigResolver/DefaultScopeConfigResolver.php
Show resolved
Hide resolved
...ishCoreBundle/DependencyInjection/Configuration/ConfigResolver/GlobalScopeConfigResolver.php
Show resolved
Hide resolved
...oreBundle/DependencyInjection/Configuration/ConfigResolver/SiteAccessGroupConfigResolver.php
Show resolved
Hide resolved
...reBundle/DependencyInjection/Configuration/ConfigResolver/StaticSiteAccessConfigResolver.php
Show resolved
Hide resolved
4 tasks
mikadamczyk
force-pushed
the
EZP-31046-chain-config-resolver
branch
2 times, most recently
from
4a4f0d4 to
8dab852
Compare
mikadamczyk
changed the title
mikadamczyk
force-pushed
the
EZP-31046-chain-config-resolver
branch
from
8dab852 to
4492898
Compare
mikadamczyk
changed the title
adamwojs
approved these changes
Jan 23, 2020
alongosz
requested changes
Jan 23, 2020
...blishCoreBundle/DependencyInjection/Configuration/ConfigResolver/ContainerConfigResolver.php
Outdated
Show resolved
Hide resolved
...lishCoreBundle/DependencyInjection/Configuration/ConfigResolver/SiteAccessConfigResolver.php
Outdated
Show resolved
Hide resolved
...lishCoreBundle/DependencyInjection/Configuration/ConfigResolver/SiteAccessConfigResolver.php
Outdated
Show resolved
Hide resolved
...lishCoreBundle/DependencyInjection/Configuration/ConfigResolver/SiteAccessConfigResolver.php
Outdated
Show resolved
Hide resolved
mikadamczyk
force-pushed
the
EZP-31046-chain-config-resolver
branch
from
0492b5b to
1333a1d
Compare
alongosz
approved these changes
Jan 23, 2020
squash! EZP-31046: Implemented ChainConfigResolver
mikadamczyk
force-pushed
the
EZP-31046-chain-config-resolver
branch
from
1333a1d to
1eaec10
Compare
micszo
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterThis PR improves ChainConfigResolver by extracting code to separate config resolvers (default, site access, site access group and global resolver). In addition, it adds type hints to Configresolver, removed Site Access relation handling (which is replaced by a dedicated method in SiteAccessService in the previous PR).
TODO:
$ composer fix-cs).