EZP-31279: Injected content domain mappers into the Repository #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
requested review from
Nattfarinn,
adamwojs,
mikadamczyk,
ViniTou and
webhdx
11 tasks
mikadamczyk
approved these changes
Jan 10, 2020
ViniTou
approved these changes
Jan 14, 2020
alongosz
force-pushed
the
ezp-31279-decouple-content-domain-mappers
branch
from
122a4cb to
d549402
Compare
alongosz
force-pushed
the
ezp-31279-decouple-content-domain-mappers
branch
2 times, most recently
from
467b228 to
6d75327
Compare
|
@adamwojs I've resolved conflict with #2844 and injected proxy factory using setter via da0f7c2. The downside to that is having the proxy factory built both in Additionally fixed minor type-hinting issue via 6d75327. |
…tTypeDomainMapper
alongosz
force-pushed
the
ezp-31279-decouple-content-domain-mappers
branch
from
6d75327 to
1e4ee38
Compare
micszo
approved these changes
Feb 26, 2020
adamwojs
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master (8.0@dev)for eZ Platformv3.0Summary
This PR makes Content Type and Content domain mappers injectable Symfony Services and injects them into the Repository instead of building them on the fly.
Moreover those mappers were moved into the proper namespace:
\eZ\Publish\Core\Repository\Helper\ContentTypeDomainMapperinto
\eZ\Publish\Core\Repository\Mapper\ContentTypeDomainMapper,\eZ\Publish\Core\Repository\Helper\DomainMapperinto
eZ\Publish\Core\Repository\Mapper\ContentDomainMapper(also renamed for better clarity).Please see distinct commits for all the changes.
Background
It's a part of a larger decoupling story. The major issue with the current architecture is a lot of cyclic dependencies and a lot of changes needed to modify direct dependencies of Repository. The good example is Content Thumbnail feature which has been implemented recently. To inject
ThumbnailStrategyservice into theContentDomainMapperwe had to modify:RepositoryFactory(x2),Repository, related tests and the domain mapper itself. This is very much not SOLID and causes cyclic dependency issues. With the changes from this PRThumbnailStrategycan be removed fromRepositoryas a follow-up. This is just one example of course.QA
You can use the
qa-cumulative-ezp-31278-31279-decouple-content-mappers-limitation-svcbranch to test both #2913 and #2914TODO:
$ composer fix-cs).