Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed index name assertion for Solr Cloud 6.X in SearchServiceTranslationLanguageFallbackTest #2928

Merged
merged 2 commits into from
Jan 29, 2020

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Jan 29, 2020

Question Answer
JIRA issue -
Bug/Improvement yes
New feature -
Target version 7.x
BC breaks no
Tests pass yes
Doc needed no

Integration tests in ezplatform-solr-search-engine@1.7 and 2.0 are using ezpublish-kernel@7.5 so SearchServiceTranslationLanguageFallbackTest should take into account index naming convention for both: Solr Clound 6.X and 7.X (which slightly differs)

Example failed build:
https://travis-ci.org/ezsystems/ezplatform-solr-search-engine/jobs/642365371?utm_medium=notification&utm_source=github_status

Example successful builds:

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs added the Bug label Jan 29, 2020
@adamwojs adamwojs self-assigned this Jan 29, 2020
@adamwojs adamwojs merged commit 41b38d4 into 7.5 Jan 29, 2020
@adamwojs adamwojs deleted the fixed_solr_cloud_intergration_tests_on_665 branch January 29, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants