Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31451: Cleaned up Content Type update handlers #2976

Merged

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Mar 5, 2020

Question Answer
JIRA issue EZP-31451
Discovered when working on #2975
Bug/Improvement yes
New feature no
Target version master (8.0@dev) for eZ Platform v3.0
BC breaks yes
Tests pass yes
Doc needed yes

This PR drops obsolete DeferredLegacy Content Type update handler. It relies on a legacy eZ Publish script so there's no sense in revamping it.
Along with dropping of class and some commented-out DIC config, the DoctrineDatabase Content Type update handler has been aligned with eZ Platform Code Style. A call using erroneous number of arguments to Content\Type\Gateway::delete method has been fixed as well (actually the root cause which triggerred a need for this PR ;) )

QA

  • Sanity on Content Type update (field adding and removal should still update existing Content items)

TODO:

  • Drop DeferredLegacy and commented-out Dependency Injection Container config.
  • Fix erroneous number of arguments in DoctrineDatabase Content Type update handler call to Gateway::delete method.
  • Align CS (+ introduce strict types).
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@micszo micszo self-assigned this Mar 9, 2020
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE master with branch.

@micszo micszo removed their assignment Mar 9, 2020
@lserwatka lserwatka merged commit 3fecadd into ezsystems:master Mar 9, 2020
@alongosz alongosz deleted the ezp-31451-cleanup-ct-update-handlers branch March 9, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants